fix: fall back to importing dynamic dependencies relative to SvelteKit package#12532
Merged
dummdidumm merged 4 commits intomainfrom Jan 15, 2025
Merged
fix: fall back to importing dynamic dependencies relative to SvelteKit package#12532dummdidumm merged 4 commits intomainfrom
dummdidumm merged 4 commits intomainfrom
Conversation
…t package Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups closes #11578
🦋 Changeset detectedLatest commit: 84a45e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6 tasks
Contributor
sunrabbit123
left a comment
sunrabbit123
left a comment
There was a problem hiding this comment.
That's a good PR.
I'm a user who wants this PR to work and yarn pnp to work.
However, I'm just sad that there hasn't been an update on this recently.
Co-authored-by: 오병진 <64676070+sunrabbit123@users.noreply.github.com>
dummdidumm
commented
Jan 13, 2025
Member
|
preview: https://svelte-dev-git-preview-kit-12532-svelte.vercel.app/ this is an automated message |
teemingc
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies code a bit around usage locations in our own code, and solves some issues people may have with their setups closes #11578
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits